Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with Svelte 5 #190

Merged
merged 17 commits into from
May 6, 2024
Merged

Make compatible with Svelte 5 #190

merged 17 commits into from
May 6, 2024

Conversation

mhkeller
Copy link
Owner

@mhkeller mhkeller commented May 3, 2024

This PR bumps up the versions in the library to make it more easily compatible with Svelte 5. It does not update the API to use runes, eliminate the use of stores or get rid of reactive statements.

@mhkeller
Copy link
Owner Author

mhkeller commented May 3, 2024

@sveltejs/vite-plugin-svelte@3.1.0 has a peerDep mismatch that will be fixed once 5.0.0 is out. I may wait until 5.0.0 is out anyway.

@mhkeller mhkeller mentioned this pull request May 3, 2024
@mhkeller
Copy link
Owner Author

mhkeller commented May 3, 2024

Credit to @rgieseke for the help on this one so far

@rgieseke
Copy link
Contributor

rgieseke commented May 6, 2024

This will be outdated soon with new Svelte 'next' releases anyways, but I think the peer dependency needs to be >=5.0.0-next.123 as 121 was breaking Layer Cake.

For more reliable testing I also did a strict versioning "svelte": "5.0.0-next.123",. Might be better to add back the caret.

@rgieseke
Copy link
Contributor

rgieseke commented May 6, 2024

The <script lang="ts"> is also in layercake-template. Maybe it needs to be changed there as well?

https://github.com/mhkeller/layercake-template/blob/3c5bd9854b8bee50b9ee61efc9c7cb207545cceb/src/routes/%2Blayout.svelte#L1

39f3081

@mhkeller
Copy link
Owner Author

mhkeller commented May 6, 2024

Good call. Fixed

@mhkeller
Copy link
Owner Author

mhkeller commented May 6, 2024

This will be outdated soon with new Svelte 'next' releases anyways, but I think the peer dependency needs to be >=5.0.0-next.123 as 121 was breaking Layer Cake.

For more reliable testing I also did a strict versioning "svelte": "5.0.0-next.123",. Might be better to add back the caret.

Added this

@mhkeller
Copy link
Owner Author

mhkeller commented May 6, 2024

i think this will be a patch version unless there's a good reason why it should be a minor version

@mhkeller mhkeller merged commit 882b3ff into main May 6, 2024
4 checks passed
@mhkeller
Copy link
Owner Author

mhkeller commented May 6, 2024

I gotta say, the website now seems a ton faster!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants