Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New API for calcExtents (Issue #44) #45

Merged
merged 27 commits into from
Jul 21, 2021
Merged

New API for calcExtents (Issue #44) #45

merged 27 commits into from
Jul 21, 2021

Commits on Jun 7, 2021

  1. Check that calcExtents doesn't modify args

    @jtrim-ons
    jtrim-ons committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    8feeb01 View commit details
    Browse the repository at this point in the history

  2. Expect {} instead of null from calcExtents

    @jtrim-ons
    jtrim-ons committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    90e4ff9 View commit details
    Browse the repository at this point in the history

  3. Test that calcExtents returns [null, null] for null/undefined/NaN input

    @jtrim-ons
    jtrim-ons committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    647d8b9 View commit details
    Browse the repository at this point in the history

  4. Test new object-based API for calcExtents

    @jtrim-ons
    jtrim-ons committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    aa50dc2 View commit details
    Browse the repository at this point in the history

  5. calcExtents: add object API, return [null, null] rather than [Infinit… 

    …y, -Infinity] and {} rather than null, don't change input args
    @jtrim-ons
    jtrim-ons committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    a6c8ea7 View commit details
    Browse the repository at this point in the history

  6. Add a comment describing the new API for calcExtents

    @jtrim-ons
    jtrim-ons committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    6261889 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2021

  1. Clarify test that ensures calcExtends() does not modify data

    @jtrim-ons
    jtrim-ons committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    5825d0c View commit details
    Browse the repository at this point in the history

  2. Throw TypeError in calcExtents(), and don't check for data.length==0

    @jtrim-ons
    jtrim-ons committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    26b27fd View commit details
    Browse the repository at this point in the history

  3. For-loop instead of forEach

    @jtrim-ons
    jtrim-ons committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    8e13356 View commit details
    Browse the repository at this point in the history

  4. Tabs instead of spaces

    @jtrim-ons
    jtrim-ons committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    15ade97 View commit details
    Browse the repository at this point in the history

  5. calcExtents tests: check TypeErrors thrown, and disallow old API

    @jtrim-ons
    jtrim-ons committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    8fff0bd View commit details
    Browse the repository at this point in the history

  6. Tabs instead of spaces

    @jtrim-ons
    jtrim-ons committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    44e23b7 View commit details
    Browse the repository at this point in the history

  7. Use ==null to check for null or undefined

    @jtrim-ons
    jtrim-ons committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    60fbc2a View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. slight tweaks to use new calcExtents API

    @mhkeller
    mhkeller committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    13ff301 View commit details
    Browse the repository at this point in the history

  2. make undefined test consistent

    @mhkeller
    mhkeller committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    c2d66e2 View commit details
    Browse the repository at this point in the history

  3. remove logs

    @mhkeller
    mhkeller committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    36ecffe View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2021

  1. add examples

    @mhkeller
    mhkeller committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    de8d794 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2021

  1. actual test

    @mhkeller
    mhkeller committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    8df3335 View commit details
    Browse the repository at this point in the history

  2. clean up

    @mhkeller
    mhkeller committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    3da8802 View commit details
    Browse the repository at this point in the history

  3. fix test

    @mhkeller
    mhkeller committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    0b16a21 View commit details
    Browse the repository at this point in the history

  4. test all

    @mhkeller
    mhkeller committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    785d5f4 View commit details
    Browse the repository at this point in the history

  5. reorder vars

    @mhkeller
    mhkeller committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    5f5ccd2 View commit details
    Browse the repository at this point in the history

  6. update comment

    @mhkeller
    mhkeller committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    6b266e4 View commit details
    Browse the repository at this point in the history

  7. update comment

    @mhkeller
    mhkeller committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    64cb6e8 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2021

  1. modify the old code w the new api

    @mhkeller
    mhkeller committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    ed0dd21 View commit details
    Browse the repository at this point in the history

  2. Use min and max variables in calcExtents

    @jtrim-ons
    jtrim-ons committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    1b619a8 View commit details
    Browse the repository at this point in the history

  3. remove minMax.js and test

    @mhkeller
    mhkeller committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    e495ada View commit details
    Browse the repository at this point in the history