Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add svelte to package.json. Fixes #54 #55

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Conversation

techniq
Copy link
Contributor

@techniq techniq commented Dec 15, 2021

No description provided.

@mhkeller mhkeller merged commit ef97573 into mhkeller:main Dec 15, 2021
@mhkeller
Copy link
Owner

Thanks @techniq !

@mhkeller
Copy link
Owner

Published as 5.0.3. Let me know how it goes.

@techniq
Copy link
Contributor Author

techniq commented Dec 15, 2021

@mhkeller Thanks for the quick release. Error is gone :)

@mhkeller
Copy link
Owner

Great. I was doing some work on the svelte-kit version. I just pushed up a version. If you want to give it a try that would be great: https://github.com/mhkeller/layercake/tree/kit

In particular I want to see if the typescript hints work.

@techniq
Copy link
Contributor Author

techniq commented Dec 15, 2021

@mhkeller I spoke too soon... out of no where (on a hot reload) I started getting Missing "./package.json" export in "d3-scale" package errors on startup and now for the life of me can't work around it.

I'm fairly certain it's because none of the d3 packages do in fact have the package.json included in their exports but then I'm also not sure I'm up for submitting a PR for the ~50+ d3 repositories and how long they would take to get merged / released.

I setup a simple StackBlitz example and going to log an issue in the SvelteKit issues to see if they have any thoughts.

What's odd is I couldn't reproduce it if I import LayerCake or d3-scale directly, but working directly with LayerChart or importing it gives these errors.

I'll let you know what I find out.

@mhkeller
Copy link
Owner

I saw that error in a quick attempt i did at npm linking the layercake.graphics repo to the package dir in the new svelte-kit layercake branch. but i wasn't sure what to make of it. one idea is that i thought it was related to better defining exports. currently, the kit branch exports all of the functions in src/lib including the helpers and utils, which previously were only internal functions. i wonder if it's trying also to make d3-scale an export? not sure.

another idea is to try to package the scaleLinear and scaleSqrt functions inside of layercake and remove that dependency – not sure how feasible that is. it also means i would want to regularly publish new versions whenever those dependencies get patches.

@mhkeller
Copy link
Owner

@techniq let's move this discussion to this issue: #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants