Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset sampling before get_std_sampled_data #51

Merged
merged 1 commit into from
Jun 29, 2016

Conversation

jmlorenzi
Copy link
Contributor

Hi Max,
Mie realized there's a problem, that I consider a bug.

How to reproduce:
Take any model, and do something like this

nrel = 1e6; nsample = 1e6  # numerical parameters
Ts = range(450,650,20)     # 20 values between 450 and 650 K
TOFs = []                  # empty list for output
# Loop over the temperature
for T in Ts:
    model.parameters.T = T   # Set the temperature
    model.do_steps(nrel)     # Relax the system
    # Sample the reactivity
    output = model.get_std_sampled_data(1, nsample, output='dict')
    # Collect output
    TOFs.append(output['CO_oxidation'])

We think that this will include the 'relaxation steps' in the sampling. IMO this should not be the case. I believe this is easily solved with this patch.

Best
Juan

@mhoffman mhoffman merged commit f15dac8 into mhoffman:develop Jun 29, 2016
@mhoffman
Copy link
Owner

Thanks. I created a new release from it (0.3.17).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants