Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RegisterDirectiveOrder for rate_limit before basic_auth #59

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Use RegisterDirectiveOrder for rate_limit before basic_auth #59

merged 3 commits into from
Jul 10, 2024

Conversation

steffenbusch
Copy link
Contributor

Fixes #58

Changes

  • Updated the init function to include RegisterDirectiveOrder.
  • Modified go.mod to upgrade the requirement from github.com/caddyserver/caddy/v2 v2.7.6 to v2.8.0.
  • Updated the README to reflect the new default order of the rate_limit directive.

mholt
mholt requested changes Jul 8, 2024
View reviewed changes
Copy link
Owner

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- we can try this; I think I agree with the placement, I just have one nit about the readme.

README.md Show resolved Hide resolved
mholt
mholt approved these changes Jul 10, 2024
View reviewed changes
Copy link
Owner

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@mholt mholt merged commit ae5d5ea into mholt:master Jul 10, 2024
3 checks passed
@steffenbusch steffenbusch deleted the directive-order branch July 14, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use RegisterDirectiveOrder for rate_limit before basic_auth
2 participants
@steffenbusch @mholt