Fix phase of first NCO output #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the first phase offset to always be `offset`. If a frequency was passed in `__call__()`, the initial phase offset was advanced by the phase increment. This is also more consistent with textbooks and MATLAB.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.0.x #238 +/- ##
==============================================
Coverage 75.67% 75.67%
==============================================
Files 48 48
Lines 2565 2565
==============================================
Hits 1941 1941
Misses 624 624 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the first phase offset to always be
offset. If a frequency was passed in__call__(), the initial phase offset was advanced by the phase increment. This is also more consistent with textbooks and MATLAB.