transaction id is string

mhujer · Aug 4, 2017 · 7d9c594 · 7d9c594
1 parent 5696b6d
commit 7d9c594
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/FioApi/Transaction.php b/src/FioApi/Transaction.php
@@ -5,7 +5,7 @@
 
 class Transaction
 {
-    /** @var float */
+    /** @var string */
     protected $id;
 
     /** @var \DateTimeImmutable */
@@ -57,7 +57,7 @@ class Transaction
     protected $specification;
 
     protected function __construct(
-        float $id,
+        string $id,
         \DateTimeImmutable $date,
         float $amount,
         string $currency,
@@ -101,7 +101,7 @@ protected function __construct(
     public static function create(\stdClass $data): Transaction
     {
         return new self(
-            $data->column22->value, //ID pohybu
+            (string) $data->column22->value, //ID pohybu
             new \DateTimeImmutable($data->column0->value), //Datum
             $data->column1->value, //Objem
             $data->column14->value, //Měna
@@ -121,7 +121,7 @@ public static function create(\stdClass $data): Transaction
         );
     }
 
-    public function getId(): float
+    public function getId(): string
     {
         return $this->id;
     }

diff --git a/tests/FioApi/TransactionTest.php b/tests/FioApi/TransactionTest.php
@@ -11,7 +11,7 @@ public function testAccountValuesAreProperlySet()
 
         $transaction = Transaction::create($transaction);
 
-        $this->assertSame((float) 1111111111, $transaction->getId());
+        $this->assertSame('1111111111', $transaction->getId());
         $this->assertEquals(new \DateTimeImmutable('2015-03-30+0200'), $transaction->getDate());
         $this->assertSame(127.0, $transaction->getAmount());
         $this->assertSame('CZK', $transaction->getCurrency());