#547 Improved Git backwards compatibility when force deleting branches.

mhutchie · Sep 18, 2021 · 5b8c7ca · 5b8c7ca
1 parent e1365c9
commit 5b8c7ca
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/src/dataSource.ts b/src/dataSource.ts
@@ -883,15 +883,11 @@ export class DataSource extends Disposable {
 	 * Delete a branch in a repository.
 	 * @param repo The path of the repository.
 	 * @param branchName The name of the branch.
-	 * @param forceDelete Should the delete be forced.
+	 * @param force Should force the branch to be deleted (even if not merged).
 	 * @returns The ErrorInfo from the executed command.
 	 */
-	public deleteBranch(repo: string, branchName: string, forceDelete: boolean) {
-		let args = ['branch', '--delete'];
-		if (forceDelete) args.push('--force');
-		args.push(branchName);
-
-		return this.runGitCommand(args, repo);
+	public deleteBranch(repo: string, branchName: string, force: boolean) {
+		return this.runGitCommand(['branch', force ? '-D' : '-d', branchName], repo);
 	}
 
 	/**

diff --git a/tests/dataSource.test.ts b/tests/dataSource.test.ts
@@ -5295,7 +5295,7 @@ describe('DataSource', () => {
 
 			// Assert
 			expect(result).toBe(null);
-			expect(spyOnSpawn).toBeCalledWith('/path/to/git', ['branch', '--delete', 'master'], expect.objectContaining({ cwd: '/path/to/repo' }));
+			expect(spyOnSpawn).toBeCalledWith('/path/to/git', ['branch', '-d', 'master'], expect.objectContaining({ cwd: '/path/to/repo' }));
 		});
 
 		it('Should force delete the branch', async () => {
@@ -5307,7 +5307,7 @@ describe('DataSource', () => {
 
 			// Assert
 			expect(result).toBe(null);
-			expect(spyOnSpawn).toBeCalledWith('/path/to/git', ['branch', '--delete', '--force', 'master'], expect.objectContaining({ cwd: '/path/to/repo' }));
+			expect(spyOnSpawn).toBeCalledWith('/path/to/git', ['branch', '-D', 'master'], expect.objectContaining({ cwd: '/path/to/repo' }));
 		});
 
 		it('Should return an error message thrown by git', async () => {