Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#557 Change contextMenuItem click to mouseup #558

Closed
wants to merge 1 commit into from
Closed

#557 Change contextMenuItem click to mouseup #558

wants to merge 1 commit into from

Conversation

githrdw
Copy link

@githrdw githrdw commented Aug 25, 2021

Issue Number / Link:
#557

Summary of the issue:
Change contextMenuItem click to mouseup

Description outlining how this pull request resolves the issue:
Changes contextMenuItem click to mouseup listener

@githrdw githrdw requested a review from mhutchie as a code owner August 25, 2021 16:16
@mhutchie
Copy link
Owner

Hi @githrdw,

Thanks for raising this improvement request and providing an implementation for it!

Please read my comment for an explanation of why I chose to implement an alternative improvement, instead of the mouseup event.

@mhutchie mhutchie closed this Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants