-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagination: pageChanged handler should accept newPageSize
when working with Asynchronous Data
#212
Labels
Comments
Looking at uigrid's code I found a clue for the way the watcher is written: |
Ok this is how I implemented this on application level, aklthoug it would be nice to be incorporated into the directive: View:
Controller:
|
Updated to avoid infinite loops in some scenarios:
Actually full credit goes to @brianchance who implemented this feature in ui-grid back in Nov 2014. |
benoror
added a commit
to benoror/ui-grid
that referenced
this issue
Aug 13, 2015
When initially loading a grid with `ui.grid.pagination` enabled, **paginationChanged** is triggered two times since the watcher values transition from `undefined` to the **initial value** Found while developing a `pageSize` feature on an alternate pagination project: michaelbromley/angularUtils#212
This was referenced Aug 13, 2015
This was referenced Jan 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When working with Asynchronous Data, a change in
pageSize
should re-trigger an async call as well (and possibly do some recalculation):itemsPerPage
in custom template #211The text was updated successfully, but these errors were encountered: