Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #38

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Update README.md #38

merged 1 commit into from
Nov 30, 2023

Conversation

BrianPulfer
Copy link
Contributor

Another typo.

@michaelfeil
Copy link
Owner

@BrianPulfer Is this related to #37?

@BrianPulfer
Copy link
Contributor Author

@BrianPulfer Is this related to #37?

Yeah, but in #37 I updated README.md and here libs/infinity_emb/README.md. I noticed there were two files after I had already submitted the first PR

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (88a5b80) 91.09% compared to head (27dd690) 91.09%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage   91.09%   91.09%           
=======================================
  Files          19       19           
  Lines         730      730           
=======================================
  Hits          665      665           
  Misses         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelfeil michaelfeil merged commit 234b6d7 into michaelfeil:main Nov 30, 2023
5 checks passed
@michaelfeil
Copy link
Owner

Ah, yes. Thats the dupicated Readme, for pypi.org - maybe could set up CI to do the duplication. Thanks!

@BrianPulfer BrianPulfer deleted the patch-2 branch November 30, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants