Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libsound for docker arm build #381

Merged
merged 3 commits into from
Sep 24, 2024
Merged

add libsound for docker arm build #381

merged 3 commits into from
Sep 24, 2024

Conversation

michaelfeil
Copy link
Owner

No description provided.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds 'libsndfile1' to the Dockerfile, enhancing audio processing capabilities for the Infinity Embedding service.

  • Added 'libsndfile1' to the apt-get install command in /libs/infinity_emb/Dockerfile
  • Supports the 'soundfile' dependency listed in /libs/infinity_emb/pyproject.toml under [tool.poetry.dependencies]
  • Enables audio-related features, potentially for embedding models that process audio input
  • Slightly increases the Docker image size due to the additional library

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings

libs/infinity_emb/Dockerfile Show resolved Hide resolved
@michaelfeil michaelfeil merged commit 228bf17 into main Sep 24, 2024
28 of 36 checks passed
@michaelfeil michaelfeil deleted the docker-arm-patch branch September 24, 2024 05:27
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.62%. Comparing base (8690ebc) to head (f02bb6c).
Report is 4 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (8690ebc) and HEAD (f02bb6c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (8690ebc) HEAD (f02bb6c)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #381       +/-   ##
===========================================
- Coverage   78.24%   65.62%   -12.63%     
===========================================
  Files          37       37               
  Lines        2781     2804       +23     
===========================================
- Hits         2176     1840      -336     
- Misses        605      964      +359     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants