Add batch requests #304
Merged
Add batch requests #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 12, 2022 23:08
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #304 +/- ##
==========================================
- Coverage 90.87% 90.31% -0.56%
==========================================
Files 34 34
Lines 2421 2551 +130
==========================================
+ Hits 2200 2304 +104
- Misses 221 247 +26 |
michaelhly
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds methods for sending and parsing RPC batch requests. Also adds
make_request_unparsedwhich acts as an escape hatch if the user doesn't want their responses parsed.The weird stuff I did with
@overloadis there because Python type hints don't have a better way of saying "I passed a tuple of parser classes and so I expect to return a tuple of instances of these classes." I added overloads for up to six request objects per batch. We can add more if somebody wants them but I think six is plenty as RPC providers have limits etc.