Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: added getInflationReward method #413

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

kubanemil
Copy link
Contributor

Fixes #316

Updated this PR #317

Added tests, however, got the same problem as in the above PR. It seems like a problem in RPC itself because testing with curl yields the same results:

raw = '{"jsonrpc":"2.0","error":{"code":-32004,"message":"Block not available for slot 8192"},"id":0}\n'
parser = <class 'solders.rpc.responses.GetInflationRewardResp'>

@michaelhly
Copy link
Owner

michaelhly commented Apr 10, 2024

@kubanemil would you mind commenting out the integration test and add the following comment:

# XXX: Block not available for slot on local cluster

@kubanemil
Copy link
Contributor Author

@michaelhly added the comment and also marked tests with @pytest.mark.skip instead of commenting them out.

Copy link
Owner

@michaelhly michaelhly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! 🙏

@michaelhly michaelhly merged commit 52ff322 into michaelhly:master Apr 11, 2024
11 of 12 checks passed
@kubanemil kubanemil deleted the issue-316 branch April 11, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No method for getInflationReward
2 participants