Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruff, switch from black to ruff, fix findings #462

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

dbast
Copy link
Contributor

@dbast dbast commented Nov 11, 2024

This PR contains separated commits to

  • Update the ruff version (requires to move settings unter tool.ruff.lint ...
  • Switch from black to ruff (ruff does black compatible formatting) + update the poetry.lock (less dependencies due to no more black)
  • Update poetry while at it
  • Apply make format (minor changes due to old black version previously used)
  • Fix / handle the remaining ruff lint finding due to new ruff rules included in the activated ruff rules set. ~100 findings where most are handled by excluding tests from some rules. (stacklevel=1 required by "B028 No explicit stacklevel keyword argument found" ... selected 1 as that is the default and also default for the new decorator in 3.13, see https://docs.python.org/3/library/warnings.html#warnings.deprecated)

No logic change of the code!

Copy link
Owner

@michaelhly michaelhly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 80.55556% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.20%. Comparing base (2119e9d) to head (e5cab61).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
+ Coverage   89.16%   90.20%   +1.03%     
==========================================
  Files          28       28              
  Lines        2271     2245      -26     
==========================================
  Hits         2025     2025              
+ Misses        246      220      -26     

@michaelhly michaelhly merged commit 3f40b01 into michaelhly:master Nov 12, 2024
13 checks passed
@dbast dbast deleted the ruff branch November 20, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants