-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add httpx session in http.py #475
Conversation
Lots of test are failing due to httpx timeout. Unsure whats the fix apart from increasing httpx default timeout |
@michaelhly Could workflow tests be approved again so I know the test were failing due to timeout rather than some logic error from this PR |
@neochine it looks like you just need to change this these tests from solana-py/tests/unit/test_client.py Line 25 in 07acdac
solana-py/tests/unit/test_async_client.py Line 25 in 07acdac
|
Alright, changed |
Looks like async test raises ReadTimeout (not ConnectError). Only sync test raises ConnectError |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #475 +/- ##
==========================================
+ Coverage 91.00% 91.01% +0.01%
==========================================
Files 28 28
Lines 2380 2383 +3
==========================================
+ Hits 2166 2169 +3
Misses 214 214 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Copied most of code from async_http.py and managed to pass ruff & mypy llinter. Tests are failing in my computer for some reason, I assume its docker related?
Fixes #474