Properly set FD_LIMIT in sysv init when installing from package #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richid
changed the title
richid
force-pushed
the
set-fd-limit-package
branch
from
62199c1 to
d7768de
Compare
|
May I ask you to consider using Chef's replacement utility? Or confirm that this change is portable between *nix OSes. |
|
Good call, didn't even think to use |
|
Thank you! |
…bian The default['cassandra']['limits']['nofile'] attribute is not used when installing from a package on Debian/Ubuntu. This change uses Chef's FileEdit utility to replace the existing value with the value specified in the attribute.
richid
force-pushed
the
set-fd-limit-package
branch
from
d7768de to
8330f01
Compare
|
Updated with your recommendations and additional testing. I also made some minor changes to the Thanks! |
michaelklishin
added a commit
that referenced
this pull request
Jul 27, 2015
Properly set FD_LIMIT in sysv init when installing from package
|
Thank you! |
|
In |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
default['cassandra']['limits']['nofile']attribute is not used wheninstalling from a package on Debian/Ubuntu. This change uses Chef's
FileEdit utility to replace the existing value with the value specified
in the attribute.
Tests pass with
rake. This has no impact on CentOS 6.5 as it already respects the attribute and it's not defined in/etc/init.d/cassandra. I tested on Ubuntu 11.04, 12.04, and 14.04 and verified that theFD_LIMITvariable is modified as expected.Thanks for the fantastic coobook!