-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #171. #172
Fixes #171. #172
Conversation
@halfninja Can you share possible values for what |
It's either a number like |
I've added a test case that was failing without the fix. As I don't know exactly how Cypress gets into this situation it directly calls getXml with some test data crafted to hit the error. |
Can you please publish this change to npm |
@BenFranzi now on npm |
Before we reassign a
number
variable to astring
, check it is still actually a number