Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve undefined property lookup on mocha file name formatting #190

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

zjkipping
Copy link
Contributor

Should help resolve issue: #178

@zjkipping
Copy link
Contributor Author

zjkipping commented Jun 14, 2023

@clayreimann @michaelleeallen Any way this can be fast tracked this is ruining a rather large monorepo on my client project.

@zjkipping
Copy link
Contributor Author

If there is a better default value other than just an empty string, I am happy to replace that. I just don't know the direction this repo would like to go on the topic.

@clayreimann
Copy link
Collaborator

@zjkipping Can you explain what happens if we generate a file with the empty string as a name?

@zjkipping
Copy link
Contributor Author

@zjkipping Can you explain what happens if we generate a file with the empty string as a name?

Currently if you had a file name of foo-[suitName]-bar it would look like foo--bar. Which is why I mentioned we might want something besides the '' default value. I figured someone else might have a better idea about that since I mostly just came to fix the fact it exits as an error currently. possibly just something like 'suitName' could be a fine default or 'undefined'.

@clayreimann
Copy link
Collaborator

Would you update the default values to be the bracketed thing that we're, maybe, replacing?

@zjkipping
Copy link
Contributor Author

@clayreimann Done, let me know if there is anything else I can do with the PR.

@clayreimann clayreimann merged commit 4cc3163 into michaelleeallen:master Jun 16, 2023
@zjkipping
Copy link
Contributor Author

@clayreimann Looks like the github actions pipelines are failing. Is that a concern for pushing out a 2.2.1 version of the npm package? Not super trying to rush you since I realize this is open source, but I would like to be able to consume this in my client project. If there is anything I can do to support a patch version publish please let me know, happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants