Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy and fix magefile #3

Closed
wants to merge 1 commit into from
Closed

tidy and fix magefile #3

wants to merge 1 commit into from

Conversation

decentralgabe
Copy link

No description provided.

@decentralgabe
Copy link
Author

@michaelneale what do you think?

@michaelneale
Copy link
Owner

Looks good. Didn’t think of the mobile requirement, nice one.

Copy link
Owner

@michaelneale michaelneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was some hard coding

}
return cmd.Wait()
logrus.Info("Successfully installed govuln")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@decentralgabe this sees to be hard coded - should be goPackage right?

@decentralgabe
Copy link
Author

@michaelneale I apologize, I was impatient and merged this into the ssi-sdk project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants