Proxy fix (with build) #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michaelolof I should apologize - even if brought up by the confusing circumstances under with we were forced to use and contribute to this repo, I nonetheless should have paid closer attention to the code submitted. |
tiagoroldao
force-pushed
the
proxy-fix-build
branch
from
c3e88e8
to
bb66627
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix #73, as tested using the following built source for close to 2 months now.
Due to issues with the built code not having been updated we continued to use our fork and as such a confusion arose when proposing the fix PR. This addresses that.
Built code is included, @michaelolof please feel free to cherrypick or request reversion.
Fixes regression caused by incomplete PR #73: