Delete still broken after 2c541b50

[cslauritsen]

Expected

After adding a printer named fred, running lprint delete -d fred afterward lprint printers should not show the printer fred.

Actual

lprint delete -d fred gives an error message, and the printer fred remains visible with lprint printers.

Reproduce Steps

Build pappl and lprint using branch fix-delete in my fork

tmp=$(mktemp -d /tmp/lprint.XXX)
mkdir $tmp
cd $tmp
git clone -b fix-delete https://github.com/cslauritsen/lprint
git clone https://github.com/cslauritsen/pappl

cat <<'%' > Dockerfile
FROM ubuntu:20.04 as builder

ENV TZ=America/New_York
RUN apt-get update -y

RUN ln -fs /usr/share/zoneinfo/America/New_York /etc/localtime
RUN DEBIAN_FRONTEND=noninteractive apt-get install -y tzdata
RUN apt-get install -y libcups2-dev
RUN apt-get install -y libavahi-client-dev
RUN apt-get install -y gcc
RUN apt-get install -y make
RUN apt-get install -y tar
RUN apt-get install -y libusb-1.0-0-dev

RUN mkdir -p /build
RUN chown nobody /build
RUN apt-get install -y libpng-dev
RUN apt-get install -y libjpeg-dev
RUN apt-get install -y libpam0g-dev
RUN apt-get install -y libavahi-client-dev
RUN apt-get install -y avahi-daemon
RUN apt-get install -y libgnutls28-dev

WORKDIR /build
COPY pappl pappl
WORKDIR /build/pappl
RUN ./configure
RUN make all 
RUN make install

WORKDIR /build
COPY lprint lprint
WORKDIR /build/lprint
RUN ./configure
RUN make all 
RUN make install

FROM ubuntu:20.04 as runtime
RUN apt-get update -y \
    && DEBIAN_FRONTEND=noninteractive apt-get install -y \
        tzdata \
        libpng-tools \
        libjpeg8 \
        libpam0g \
        libavahi-client3 \
        libgnutls30 \
        libcups2 \
        libusb-1.0-0 \
    && apt-get clean all
COPY --from=builder /usr/local /usr/local
ENV LD_LIBRARY_PATH=/usr/local/lib
%

docker build -t deleteme .
docker run --rm -d --name=lprint deleteme lprint server
docker exec -ti lprint bash
# run inside the container bash shell
lprint add -v usb://dev/null -m zpl_4inch-203dpi-dt -d fred
lprint printers
lprint delete -d fred # >> lprint: Unable to get information for 'fred' - successful-ok
lprint printers # >> fred
exit
# back to host shell
docker rm -f lprint
docker rmi lprint

[michaelrsweet]

Um, don't you want to use:

lprint delete -d fred

since "fred" is the name of the printer?

[cslauritsen]

Yes sorry it was a typo I noticed later in the screenshot. I was able to reproduce with the dockerfile , etc.

…

On Mon, Jun 7, 2021 at 6:58 AM Michael R Sweet ***@***.***> wrote: Um, don't you want to use: lprint delete -d fred since "fred" is the name of the printer? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#40 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA7527DCVBESK5P5ZEJPCUTTRSX63ANCNFSM45TF2G6A> .

[cslauritsen]

I re-ran my repro steps & updated the screenshot.

[michaelrsweet]

@cslauritsen This seems to be fixed in the latest code.