Revert DYMO label margins to values prior to DYMO tape printing being added #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When DYMO tape printing support was added in ed195b5 and 6f49c6e, the label left/right margin was changed from 100 to 367 and the bottom/top margin from 525 to 1. This causes the label content to be offset both vertically and horizontally with reference to the label. The margin values are stored in the state file along with the other media details so it is necessary to re-select the media size (or remove the state file) for this change to take effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When DYMO tape printing support was added in ed195b5 and 6f49c6e, the label
left_rightmargin was changed from 100 to 367 and thebottom_topmargin from 525 to 1.In my limited testing (I currently only have a LabelWriter 450 and 1.4 x 3.5" Large Address labels to test it with), these values cause the label content to be offset both vertically and horizontally with respect to the label. For instance, after selecting the correct media, printing the test page gives me this result (next label manually ejected too for clarity):
The commit in this PR restores the values to what they were prior to ed195b5 and gives me the following result from the test page:
This was initially a bit of a head-scratcher for me because I hadn't realised that the margins are stored in the state file and only updated when media is selected (or re-selected).