Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server-ipp.c: set the current datetime to startup time, if no printer… #26

Closed
wants to merge 1 commit into from
Closed

Conversation

zdohnal
Copy link
Contributor

@zdohnal zdohnal commented Sep 9, 2020

…s available

Hi,

when you ran lprint server but you don't have any device capable of working with lprint and if you issue:

lprint status

from other terminal, the return time is the beginning of linux timestamp - 1 hour - 1st Jan 1970.

It is because ipp attribute system-state-change-date-time contains 0, because there are no found printers - their state time is used otherwise.

My proposed fix is to set state_time to system->start_time if no printers are available, but I'm not sure how to handle system-state-change-time attribute - it contained a negative integer before the proposed fix, now it will contain zero - can the attribute be ignored if value is zero?

Either way, please let me know if original fix is ok or should I change something.

Thank you in advance,

Zdenek

@michaelrsweet
Copy link
Owner

I think this is already fixed in PAPPL, but I'll make sure when I push those changes through.

@michaelrsweet michaelrsweet self-assigned this Sep 10, 2020
@michaelrsweet michaelrsweet added the bug Something isn't working label Sep 10, 2020
@michaelrsweet michaelrsweet added this to the v1.0.x milestone Sep 10, 2020
@michaelrsweet michaelrsweet modified the milestones: v1.0.x, v1.1.x Nov 15, 2020
@michaelrsweet
Copy link
Owner

This is fixed with PAPPL 1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants