Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with MXML_CUSTOM in Version mxml-2.10 #201

Closed
mkoennecke opened this issue Jul 14, 2017 · 1 comment
Closed

Problem with MXML_CUSTOM in Version mxml-2.10 #201

mkoennecke opened this issue Jul 14, 2017 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mkoennecke
Copy link

Hi,

I am using the MXML_CUSTOM element together with custom callbacks for loading and writing.
This all worked well for years but broke with version 2.10. I tracked it down to line 2928 of file mxml-file.c. In the distributed version the line reads:

if ((data = (*global->custom_save_cb)(node)) == NULL)

but it must read:

if ((data = (*global->custom_save_cb)(current)) == NULL)

With that change my code continued to work again. Please adopt my fix for version 2.11

@michaelrsweet michaelrsweet self-assigned this Aug 3, 2017
@michaelrsweet michaelrsweet added the bug Something isn't working label Aug 3, 2017
@michaelrsweet michaelrsweet added this to the Stable milestone Aug 3, 2017
@michaelrsweet
Copy link
Owner

[master ef7e5d4] Fix writing of custom data nodes (Issue #201)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants