Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit a084198be8e0278513c7fa1677442e4312a794ac breaks applications #259

Closed
LordOfDragons opened this issue Jul 4, 2019 · 4 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@LordOfDragons
Copy link

This commit today broke our application. The standard states that the <?xml is optional in xml version 1.0 . So far we used a check if the returned element is the xml declaration (with the actual xml node as child) or the actual xml node itself.

Because this commit contradicts the XML standard I would kindly request to revert the commit or to make this behaviour configurable (and disabled by default).

Reference: https://www.w3.org/TR/xml/#sec-prolog-dtd

@michaelrsweet michaelrsweet self-assigned this Jul 4, 2019
@michaelrsweet michaelrsweet added the bug Something isn't working label Jul 4, 2019
@michaelrsweet michaelrsweet added this to the Stable milestone Jul 4, 2019
@michaelrsweet
Copy link
Owner

Hmm, investigating - this is the #1 issue with users of Mini-XML trying to load documents that are not well-formed...

@LordOfDragons
Copy link
Author

Well, according to xml standard no character is allowed to show up before <?xml or a well-formed node. I think using the check " is '<?xml' or '<'" instead of "is '<?xml' " should help both cases

@michaelrsweet
Copy link
Owner

OK, I'll pull the requirement for <?xml at the start but not < (i.e. the first character needs to be <).

michaelrsweet added a commit that referenced this issue Jul 8, 2019
…ion for

some applications and the XML 1.0 specification only requires an XML file to
start with '<' (Issue #259)
@michaelrsweet
Copy link
Owner

[master e2f7978] Roll back part of the change for Issue #256 since it causes a regression for some applications and the XML 1.0 specification only requires an XML file to start with '<' (Issue #259)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants