Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some job processing controls for proofing/copies #266

Closed
michaelrsweet opened this issue Mar 10, 2023 · 5 comments
Closed

Some job processing controls for proofing/copies #266

michaelrsweet opened this issue Mar 10, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request priority-high
Milestone

Comments

@michaelrsweet
Copy link
Owner

michaelrsweet commented Mar 10, 2023

Proposed additions:

...
  PAPPL_JREASON_JOB_CANCELED_AFTER_TIMEOUT = 0x00800000, // 'job-canceled-after-timeout'
  PAPPL_JREASON_JOB_FETCHABLE = 0x01000000, // 'job-fetchable'
  PAPPL_JREASON_JOB_SUSPENDED_FOR_APPROVAL = 0x02000000 // 'job-suspended-for-approval'
...

// Return the job to the 'pending' or 'processing' state from 'processing-stopped', removing specified reasons as needed
extern void pappJobResume(pappl_job_t *job, pappl_jreason_t remove) _PAPPL_PUBLIC;

// Stop/suspend a 'processing' job to the 'processing-stopped' state, adding specified reasons as needed
extern void pappJobSuspend(pappl_job_t *job, pappl_jreason_t add) _PAPPL_PUBLIC;

These will go along with the changes for #265 to support proof print copies, INFRA, and the "job-cancel-after-xxx" Job Template attributes.

@michaelrsweet michaelrsweet added enhancement New feature or request priority-high labels Mar 10, 2023
@michaelrsweet michaelrsweet added this to the v1.4 milestone Mar 10, 2023
@michaelrsweet michaelrsweet self-assigned this Mar 10, 2023
@wifiprintguy
Copy link
Contributor

Thanks - I'll copy / paste this into my own branch to move forward.

@michaelrsweet
Copy link
Owner Author

Renaming functions to papplJobResume and papplJobSuspend.

@wifiprintguy
Copy link
Contributor

papplJobResume() is already defined with a different parameter signature, unless I've gotten my fetches and rebases all messed up (again)...

@michaelrsweet
Copy link
Owner Author

@wifiprintguy That's certainly possible, current master has these in job.h:

extern void		pappJobResume(pappl_job_t *job, pappl_jreason_t remove) _PAPPL_PUBLIC;
extern void		pappJobSuspend(pappl_job_t *job, pappl_jreason_t add) _PAPPL_PUBLIC;

@michaelrsweet
Copy link
Owner Author

[master 8f9f09c] Add support for suspend/resume of jobs (Issue #266)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-high
Projects
None yet
Development

No branches or pull requests

2 participants