Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging Cleanup #270

Closed
michaelrsweet opened this issue Mar 29, 2023 · 1 comment
Closed

Logging Cleanup #270

michaelrsweet opened this issue Mar 29, 2023 · 1 comment
Assignees
@michaelrsweet
Labels
enhancement New feature or request priority-high
Milestone
v1.4

Comments

@michaelrsweet
Copy link
Owner

Investigate logging cleanup, either to move some debug messages to info or to add an additional log level beyond "debug" for things like the following messages:

Opening device for status/maintenance.
Done using device for status/maintenance.
Closing device.

These can clutter up the logs when we just want to see basic job/printer state changes/info.

If the current log levels are insufficient, add a new all/debug2 level for the noisy stuff.
@michaelrsweet michaelrsweet self-assigned this Mar 29, 2023
@michaelrsweet michaelrsweet added enhancement New feature or request priority-high labels Mar 29, 2023
@michaelrsweet michaelrsweet added this to the v1.4 milestone Mar 29, 2023
michaelrsweet added a commit that referenced this issue Jun 23, 2023
@michaelrsweet
Logging cleanup (Issue #270)
4c0d022 
- Reduce chattiness of debug logs - commented out device open/close logging as
  it might be useful to track down issues, but we don't need to hear about non-
  issues.
- Protect against invalid log level values being sent by a printer application.
  This shouldn't happen (compiler warnings/etc.) but it doesn't cost us much to
  flag them.
@michaelrsweet
Copy link
Owner Author

[master 4c0d022] Logging cleanup (Issue #270)

Kept the same log levels - for 2.0 maybe we add a debug2 level, but for now debug is the most chatty.

Also updated write_log to protect against invalid log level constants...

michaelrsweet added a commit that referenced this issue Sep 28, 2023
@michaelrsweet
Logging cleanup (Issue #270)
ce25c71 
- Reduce chattiness of debug logs - commented out device open/close logging as
  it might be useful to track down issues, but we don't need to hear about non-
  issues.
- Protect against invalid log level values being sent by a printer application.
  This shouldn't happen (compiler warnings/etc.) but it doesn't cost us much to
  flag them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelrsweet michaelrsweet

Labels
enhancement New feature or request priority-high
Projects
None yet
Milestone
v1.4
Development

No branches or pull requests
1 participant
@michaelrsweet