Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"printer-settable-attributes" and _papplPrinterSetAttributes are inconsistent #311

Closed
szlt5 opened this issue Nov 28, 2023 · 4 comments
Closed
Assignees
Labels
bug Something isn't working priority-low
Milestone

Comments

@szlt5
Copy link

szlt5 commented Nov 28, 2023

Is your feature request related to a problem? Please describe.
I found the "printer-settable-attributes" acquired by IPP is inconsistent with the acceptable attributes in the function _papplPrinterSetAttributes().

Would it be more appropriate to change them consistent?

Additional Information
The “printer-settable-attributes" is acquired by following command:

ipptool -tv ipp://localhost:8000/ipp/print/foo get-printer-attributes-3.0.test

None

@michaelrsweet
Copy link
Owner

"document-format-default" shouldn't be listed.

"output-bin-default", "printer-contact-col", and "sides-default" should be listed.

@michaelrsweet michaelrsweet self-assigned this Nov 28, 2023
@michaelrsweet michaelrsweet added bug Something isn't working priority-low labels Nov 28, 2023
@michaelrsweet michaelrsweet added this to the Stable milestone Nov 28, 2023
@szlt5
Copy link
Author

szlt5 commented Nov 30, 2023

Now, only the master branch can set "copy-default", it is helpful to accept the "copies-default" in the function _papplPrinterSetAttributes() for the branch 1.4.x.

@michaelrsweet
Copy link
Owner

@szlt5 The pappl_pr_driver_data_t structure in 1.x does not support copies - 1.x assumed that the printers supported by the various drivers would not be able to usefully support copy generation and didn't expose it. So "copies-default" needs to be a 2.0 and later feature...

@michaelrsweet
Copy link
Owner

[master 2d25c1d] Update the printer-settable-attributes-supported values (Issue #311)

[v1.4.x 1e28cdf] Update the printer-settable-attributes-supported values (Issue #311)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-low
Projects
None yet
Development

No branches or pull requests

2 participants