Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --runstatedir configure option. #126

Closed
wants to merge 2 commits into from

Conversation

OdyX
Copy link

@OdyX OdyX commented Jan 15, 2021

Debian's autoheader doesn't support partial AC_DEFINE_UNQUOTED or AC_DEFINE calls; these two need all 3 arguments.

@michaelrsweet
Copy link
Owner

@OdyX Please don't run autoheader on my projects. I don't use it. I don't use automake. I don't use libtool. There is a reason - they make maintaining the build system on non-Linux systems impossible. They introduce dependencies on other GNU tools that I don't want. The only reason I'm even using autoconf is because there isn't a viable alternative - cmake has its own baggage and requires cmake to be installed on the build system, and PAPPL has too many dependencies to just use a simple makefile (like I do in some of my other projects).

TL;DR: Do not treat PAPPL as a GNU project. It isn't.

@michaelrsweet michaelrsweet self-assigned this Jan 15, 2021
@michaelrsweet michaelrsweet added the wontfix This will not be worked on label Jan 15, 2021
@OdyX
Copy link
Author

OdyX commented Jan 15, 2021

Fair enough. I don't see the point of shipping .ac files with broken syntax. I'll build without autoreconf, no big problem.

@michaelrsweet
Copy link
Owner

@OdyX The syntax is not broken, it is just missing the optional information that autoheader depends on. I can certainly drop the configure.as file from the source tarball.

@OdyX
Copy link
Author

OdyX commented Jan 15, 2021

The problem I now run into is that Debian build tools rely on ./configure to support autotools-standard config options such as --runstatedir. The ./configure as shipped doesn't support this. I'll find a way.

@michaelrsweet
Copy link
Owner

@OdyX The correct solution here is to ask for --runstatedir support and not (essentially) for automake support (which opens up a rather large can of worms that I want to avoid...)

I'll re-open for that issue (although I'm not sure what I'd map --runstatedir to since the printer application doesn't have to run as root...)

@michaelrsweet michaelrsweet reopened this Jan 15, 2021
@michaelrsweet michaelrsweet changed the title Fix autoconf syntax Add support for --runstatedir configure option. Jan 15, 2021
@michaelrsweet michaelrsweet added bug Something isn't working platform issue Issue is specific to an OS or desktop priority-low and removed wontfix This will not be worked on labels Jan 15, 2021
@michaelrsweet michaelrsweet added this to the v1.1 milestone Jan 15, 2021
@michaelrsweet
Copy link
Owner

OK, looks like I just need to use the recently-released autoconf 2.70 to build the configure script. I'm fixing some warnings about deprecated macros and will push some changes (for 1.1, not going to mess with the configure script for 1.0.x) that will give you --runstatedir. However, at the moment the value won't be used (although I might try hooking it up to the mainloop API which chooses the state file for the printer application...)

@michaelrsweet
Copy link
Owner

Tracking directory/file changes in #128.

@OdyX
Copy link
Author

OdyX commented Jan 15, 2021

Great, thank you for extracting the actionable out of my PR; and sorry if my PR (apparently the 3rd or 4th about autoconf you had closed, sorry for that) was premature.

@michaelrsweet
Copy link
Owner

OK, I've made extensive changes to the configure script source, not only to resolve warnings from autoconf 2.70 but to transition most of the shell script stuff over to the AS_xxx macros. I also added an explicit AC_DEFINE([PAPPL_DOES_NOT_USE_AUTOHEADER_OR_AUTOMAKE]) to cause autoheader to fail and print the message for posterity... :)

[master 5d6c0e1] One more set of updates, this time to use AS_xxx macros instead of raw shell commands. We aren't able to cover everything (there is no AS_FOR macro) but we have covered most of the things.

michaelrsweet added a commit that referenced this pull request Jan 15, 2021
OdyX added a commit to OdyX/pappl that referenced this pull request Jan 20, 2021
michaelrsweet added a commit that referenced this pull request Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform issue Issue is specific to an OS or desktop priority-low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants