Adding support to PAPPL for converting non-eSCL scanners to eSCL Servers #249

Kappuccino111 · 2023-01-19T07:24:36Z

@tillkamppeter @michaelrsweet This is an update on the documentation aspect of scanning in PAPPL. The document generation was done using code-doc. Also additional changes have been made in pappl-body.md to update the scanning implementation. With this now we have a clear insight on the issue #130 and the changes that are to be implemented.

Body of this file has been built upon updated pappl-body.md

Updates for various scanning implementations

tillkamppeter · 2023-02-14T21:46:52Z

pappl/base-private.h

@@ -6,7 +6,7 @@
 // Licensed under Apache License v2.0.  See the file "LICENSE" for more
 // information.
 //
-
+extern char **environ;
 #ifndef _PAPPL_BASE_PRIVATE_H_


Why that? (move extern char **environ;)

@tillkamppeter I have now moved it to the correct place.

tillkamppeter · 2023-02-14T21:47:10Z

pappl/base-private.h

 #    define O_BINARY	0		// I hate Windows...
 #  endif // _WIN32


-//
+// @private@


@tillkamppeter the @ private @ is a feature in code-doc to preventing comment logging of specific functions which are not required in the docs. This prevents functions from being logged in the documentation.

tillkamppeter · 2023-02-14T22:02:32Z

pappl/job-process.c

+
+
+pappl_sc_options_t *			// O - Job options data or `NULL` on error
+papplJobCreatescanOptions(


papplJobCreateScanOptions( ^ Upper Case!

@tillkamppeter fixed it.

tillkamppeter · 2023-02-14T22:04:56Z

pappl/job-process.c

+    unsigned         num_pages,		// I - Number of pages (`0` for unknown)
+    bool             color)		// I - Is the document in color?
+{
+  pappl_sc_options_t	*options;	// New options data


Please check all options and choices here. Do they really all make sense with a scanner?

Please also check the eSCL standard. Which options and choices are available there?

@tillkamppeter some eSCL aspects are missing or need re-structuring. At the moment the base implementation is done and this will be updated in the near future as we will be having more dependencies later on.

The function was redundant.

Kappuccino111 · 2023-06-05T18:05:36Z

@tillkamppeter, the base line implementation of xml-parser has now been pushed as xml-parser.c

Kappuccino111 · 2023-06-28T19:00:36Z

@tillkamppeter , I have updated the repository with my current implementation. Could you please check through it.

Kappuccino111 · 2023-07-09T13:59:51Z

@michaelrsweet @tillkamppeter ...
Here is the update on my progress so far:

The client requests the scanner’s ScannerCapabilities document by sending an HTTP GET request to the PAPPL scanner URL.
We respond by sending the scanner capabilities document. Currently, we are using a dummy driver setup that has the Scanner Properties already in the form of an XML document. In the future, these will be acquired from the scanner on server start.
Based on the information in the ScannerCapabilities XML document, the client creates a ScanSettings XML document and uses an HTTP POST request to send it to the Scanner URI, appended with "ScanJobs".
We read the POST request, extract the information, and store them in different variables.

The extraction and storage aspects of the job variables are implemented in escl-ops.c, while the GET-POST handling is handled by the papplClientProcessHTTP() function located in client.c. The dummy files are housed in the "Dummy Driver" folder.

At this juncture, we will transition to the scan job creation phase. Can we discuss my implementation so far, so I can proceed to generate scan job tickets accordingly?

This discussion is crucial, as it establishes the foundation for client-server interaction. It will also necessitate the elimination of some redundant code from previous phases.

tillkamppeter · 2023-07-09T19:33:22Z

pappl/client.c

-// Copyright © 2019-2022 by Michael R Sweet.
-// Copyright © 2010-2019 by Apple Inc.
+// Copyright \u00a9\u00a02019-2022 by Michael R Sweet.
+// Copyright \u00a9 2010-2019 by Apple Inc.


Here (and at many other places in your code) seems to be a problem with UTF-8 character encoding. Please check.

@tillkamppeter I have updated this in 7f1922c .

tillkamppeter · 2023-07-09T20:12:27Z

pappl/client-webif.c

@@ -1,7 +1,7 @@
 //
 // Core client web interface functions for the Printer Application Framework
 //
-// Copyright © 2019-2022 by Michael R Sweet.
+// Copyright © 2019-2022 by Michael R Sweet.


This looks strange. What happened here?

Yes, I had to reformat the file and hence we are getting the above.

Kappuccino111 added 18 commits January 19, 2023 01:38

Update for better codedoc parsing

68ccc82

Update for better codedoc parsing

50e6683

Update for better codedoc parsing

b44151d

Update scanning implementations

5429058

Update for scanning implementation using codedoc

ed10846

Body of this file has been built upon updated pappl-body.md

Updating Links.c to update papplScannerRemoveLink

9924dff

Update system-accessors.c

85bb95d

Updates for various scanning implementations

Updating system-private.h

35ef686

Updating client-webif.c with scan implementations

7520b7a

Updating client-accessors.c with scan implementations

19a66b1

Update job-accessors.c

7696170

Update job-accessors file for scan implemenat

d6d0f7c

Update scanner.h according to needs of implementation of scanning

17f9fb4

Update system.h after scan implementation

0830028

Updating various functions for scanning implementations

2b9880e

Updating copyright info

a89a977

Updating job-process.c with scan implementations

5f107d2

Updating minor changes

3db54dc

tillkamppeter reviewed Feb 14, 2023

View reviewed changes

Kappuccino111 added 7 commits February 18, 2023 16:40

Updating position of "extern char environ"

75ada28

General Updates

3b8a0cf

Creating file for USB Supported Scanning

4ba7090

Removing papplScannerGetScanGroup function

4f54374

The function was redundant.

Adding scanner-xml.h for escl-parser support

f1a102d

Adding client-escl.c for parsing for Scanner Capabilities.

53708f8

Creating xml-parser baseline implementation.

c47f965

Kappuccino111 added 4 commits June 28, 2023 18:53

Delete escl-ops.c

05f0a26

Delete escl-ops.h

aa2612c

Adding escl-ops.c in pappl directory

df632a6

Update client.c for GET and POST requests.

b74724d

Kappuccino111 changed the title ~~Updating the scanning implementations using codedoc~~ Converting non-eSCL scanners to eSCL Servers Jul 9, 2023

Kappuccino111 added 5 commits July 9, 2023 16:51

Updating indentation in ScannerStatus.xml

4e80adc

Update indentation in ScannerCapabilities.xml

7da8f74

Deleting redundant escl.o file

5802ac5

Update escl-ops.c with necessary indents and comments

693bbfb

Update escl-ops.h with necessary format.

66bb5f0

Kappuccino111 changed the title ~~Converting non-eSCL scanners to eSCL Servers~~ Adding support to PAPPL for converting non-eSCL scanners to eSCL Servers Jul 9, 2023

Kappuccino111 added 2 commits July 9, 2023 18:48

Update client.c with necessary indentation and comments

7f1922c

Deleting redundant file xml_parser.c

8c53f39

tillkamppeter reviewed Jul 9, 2023

View reviewed changes

Kappuccino111 added 12 commits August 13, 2023 07:58

Changes In Configure and Makefile to include libxml

3715760

Autogen file for aclocal

e352634

Fixing any formatting errors

5f7e257

File containing Data Structures and XML creation

c56f109

Adding extra end line at EOF

aa6355e

Fixing formatting

e2dc822

Updating Dummy Driver Files

d7fdce8

Updating Make and Status Files

b40fbcd

Updating client connection files

aa9d6cb

Updating PAPPL makefile

891b9be

Updating IP handler files

7de9732

Updating Scanner Capabilities Files

7c07317

Kappuccino111 closed this Mar 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding support to PAPPL for converting non-eSCL scanners to eSCL Servers #249

Adding support to PAPPL for converting non-eSCL scanners to eSCL Servers #249

Kappuccino111 commented Jan 19, 2023

tillkamppeter Feb 14, 2023 •

edited

Loading

Kappuccino111 Feb 18, 2023

tillkamppeter Feb 14, 2023

Kappuccino111 Feb 18, 2023

tillkamppeter Feb 14, 2023

Kappuccino111 Feb 18, 2023

tillkamppeter Feb 14, 2023

tillkamppeter Feb 14, 2023

Kappuccino111 Feb 18, 2023

Kappuccino111 commented Jun 5, 2023

Kappuccino111 commented Jun 28, 2023

Kappuccino111 commented Jul 9, 2023 •

edited

Loading

tillkamppeter Jul 9, 2023

Kappuccino111 Jul 9, 2023

tillkamppeter Jul 9, 2023

Kappuccino111 Jul 15, 2023



		pappl_sc_options_t * // O - Job options data or `NULL` on error
		papplJobCreatescanOptions(

Adding support to PAPPL for converting non-eSCL scanners to eSCL Servers #249

Adding support to PAPPL for converting non-eSCL scanners to eSCL Servers #249

Conversation

Kappuccino111 commented Jan 19, 2023

tillkamppeter Feb 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kappuccino111 commented Jun 5, 2023

Kappuccino111 commented Jun 28, 2023

Kappuccino111 commented Jul 9, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tillkamppeter Feb 14, 2023 •

edited

Loading

Kappuccino111 commented Jul 9, 2023 •

edited

Loading