log.c: Fix crash due negative buffer size #272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A higher pointer address is subtracted from lower pointer address in `write_log`, which causes crash if pappl is built with _FORTIFY_SOURCE=3. It can be reproduced by starting `lprint` service.
zdohnal
force-pushed
the
write_log_overflow
branch
from
f132969
to
0edc517
Compare
|
Ok, I didn't know Github project can be set to require signing - learnt something new :) . |
michaelrsweet
added a commit
that referenced
this pull request
Apr 12, 2023
michaelrsweet
added
bug
|
Thanks, @michaelrsweet ! |
michaelrsweet
added a commit
that referenced
this pull request
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A higher pointer address is subtracted from lower pointer address in
write_log, which causes crash if pappl is built with _FORTIFY_SOURCE=3.It can be reproduced by starting
lprintservice.