Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix netcat hang when it send raw data to raw socket #338

Closed
wants to merge 2 commits into from
Closed

Fix netcat hang when it send raw data to raw socket #338

wants to merge 2 commits into from

Commits on Feb 9, 2024

  1. Fix netcat hang when it send raw data to raw socket 

    netcat and similar tools hang when they send data to PAPPL's raw socket.
It is because these tools wait for input from the destination, and we
never end because update `activity` every time `poll()` returns
non-negative value, and the tools never send POLLHUP.

The proposed fix is to update `activity` only when we read from the
socket, and break out of the loop after 10s of inactivity.

Fixes michaelrsweet#331
    @zdohnal
    zdohnal committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    1579e05 View commit details
    Browse the repository at this point in the history

  2. Fix tabs/spaces

    @zdohnal
    zdohnal committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    7863f32 View commit details
    Browse the repository at this point in the history