List raw sockets during printers subcommand if available
#340
+56
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdohnal
changed the title
printers subcommand if availableprinters subcommand if available
zdohnal
force-pushed
the
list-raw-sockets
branch
from
ff683a2
to
1d497ad
Compare
Provide a way how to show path to raw socket via CLI without 3rd part tools.
zdohnal
force-pushed
the
list-raw-sockets
branch
from
658e938
to
006c0ba
Compare
zdohnal
changed the title
printers subcommand if availableprinters subcommand if available
michaelrsweet
requested changes
Mar 22, 2024
| } | ||
|
|
||
| if (printer_name && printer_uri) | ||
| printf("%s - printer - %s\n", printer_name, printer_uri); |
There was a problem hiding this comment.
Not keen on the format here - better to display the raw URL separately, e.g.:
PRINTER-NAME
ipp://HOSTNAME:PORT/ipp/print/PRINTER-NAME
ipps://HOSTNAME:PORT/ipp/print/PRINTER-NAME
socket://HOSTNAME:PORT
There was a problem hiding this comment.
Also, any text would need to be localized, so the above format avoids that particular issue...
|
|
||
| if (printer->raw_active) | ||
| { | ||
| if (!ra || cupsArrayFind(ra, "smi55357-printer-socket-uri-supported")) |
There was a problem hiding this comment.
How about "smi55357-socket-uri-configured"? You need to configure for raw printing support and we don't need to have "printer" in the name.
| if (attr == NULL) | ||
| break; | ||
|
|
||
| value_tag = IPP_TAG_CUPS_INVALID; |
There was a problem hiding this comment.
I don't think you need to initialize a default attr_name or value_tag value. And printer-uri-supported is multi-valued so we might as well show all of the values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a way how to show path to raw socket via CLI without 3rd part tools.