Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Pixi 7.1 events #306

Merged
merged 2 commits into from
Jan 13, 2023
Merged

Support Pixi 7.1 events #306

merged 2 commits into from
Jan 13, 2023

Conversation

zOadT
Copy link
Contributor

@zOadT zOadT commented Nov 24, 2022

Utilizes the work in pixijs/pixijs#8876 to support event handler props for Pixi.js >= 7.1

Note: Pixi.js 7.1 isn't released yet and I also have to test the typings for Pixi < 7

@codesandbox
Copy link

codesandbox bot commented Nov 24, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@zOadT zOadT mentioned this pull request Nov 24, 2022
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1110ef6:

Sandbox Source
React Configuration
React Typescript Configuration
examples Configuration
React Pixi Fiber template Configuration
React Pixi Fiber TypeScript template Configuration
React Pixi Fiber demo – Rotating Bunny Configuration
React Pixi Fiber demo – AnimatedSprite Configuration
react-pixi-fiber text alignment Configuration
React Pixi Fiber with Redux Configuration
React Pixi Fiber demo – Animated.ValueXY Configuration

@zOadT
Copy link
Contributor Author

zOadT commented Jan 11, 2023

Hey! Pixi.js 7.1 got released yesterday. I tested this branch with pixi.js 7.1 and pixi.js 6.5.1 and it seems to work fine for both of them.

I found another issue with pixi.js 7.1 (unrelated to this PR) though. But I would open an issue for that and handle that in another PR if that's ok.

@zOadT zOadT marked this pull request as ready for review January 11, 2023 19:00
@michalochman
Copy link
Owner

Hi @zOadT, please do!

@zOadT
Copy link
Contributor Author

zOadT commented Jan 12, 2023

Hello @michalochman, the issue I meant is #311. I want to handle that separately (because it is unrelated) but actually still wanted to get this PR merged 😅 (of course only if you don't have any issues with this PR)

@michalochman michalochman reopened this Jan 13, 2023
@michalochman
Copy link
Owner

Sorry @zOadT! I misunderstood and thought your changes are not needed after fix in PixiJS 7.1.

@michalochman
Copy link
Owner

Now I remember that they have prepended event props with on. Looks good, thanks for your contribution.

@michalochman michalochman merged commit f3f9c12 into michalochman:master Jan 13, 2023
@zOadT
Copy link
Contributor Author

zOadT commented Jan 13, 2023

No problem, thank you! 🙂

@zOadT zOadT deleted the pixijs-7.1 branch January 13, 2023 15:30
@michalochman
Copy link
Owner

Released in react-pixi-fiber@1.0.6 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants