-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Pixi 7.1 events #306
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1110ef6:
|
Hey! Pixi.js 7.1 got released yesterday. I tested this branch with pixi.js 7.1 and pixi.js 6.5.1 and it seems to work fine for both of them. I found another issue with pixi.js 7.1 (unrelated to this PR) though. But I would open an issue for that and handle that in another PR if that's ok. |
Hi @zOadT, please do! |
Hello @michalochman, the issue I meant is #311. I want to handle that separately (because it is unrelated) but actually still wanted to get this PR merged 😅 (of course only if you don't have any issues with this PR) |
Sorry @zOadT! I misunderstood and thought your changes are not needed after fix in PixiJS 7.1. |
Now I remember that they have prepended event props with |
No problem, thank you! 🙂 |
Released in |
Utilizes the work in pixijs/pixijs#8876 to support event handler props for Pixi.js >= 7.1
Note: Pixi.js 7.1 isn't released yet and I also have to test the typings for Pixi < 7