Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

randomizing discovery responses and adding tradfri #20

Merged
merged 3 commits into from
Jun 26, 2017

Conversation

thexperiments
Copy link
Contributor

the order of the discovery responses is now randomized so it should be a bit easier to add more than 16 devices with a few searches through the echo (worked great for me)

I also added the tradfri lights, works great.

Thanks for the plugin.

@michbeck100 michbeck100 merged commit 8d551d4 into michbeck100:master Jun 26, 2017
@michbeck100
Copy link
Owner

Thanks for your contribution! I see if i can ultimately fix the device limitation with #14. But for now, your changes are great.

@thexperiments
Copy link
Contributor Author

Sure would be better. I think what I did is just a hack but it worked quite well for me. I don't know if multiple upnp listeners would help maybe you could test this with two instances of pimatic running with 16 devices each and ask the echo to search for devices. For my setup I always get "I found 16 smart home devices" when triggering via voice so this is a better indicator than the app.

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants