Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

Prevent infinite loops when switching #29

Closed
michbeck100 opened this issue Mar 24, 2016 · 1 comment
Closed

Prevent infinite loops when switching #29

michbeck100 opened this issue Mar 24, 2016 · 1 comment
Labels
bug
Milestone
0.6.2

Comments

@michbeck100
Copy link
Owner

Some switch implementations aren't safe when switching from on to on. This can cause an infinite loop of events and event handlers.
@michbeck100 michbeck100 added this to the 0.6.2 milestone Mar 24, 2016
@michbeck100 michbeck100 mentioned this issue Mar 25, 2016
Closed
michbeck100 added a commit that referenced this issue Mar 25, 2016
@michbeck100
Removed duplicated code for switching dimmer and powerswitch on or of…
6ea1f8e 
…f. Moved logic to switch.

#29 make sure that only if state changed device gets toggled
michbeck100 added a commit that referenced this issue Mar 25, 2016
@michbeck100
#29 remember current state of dimmer and switch in local variable. Ad…
28cdb54 
…ded test to verify behavior
michbeck100 added a commit that referenced this issue Mar 26, 2016
@michbeck100
#29 fixing infinite loop for dimmers
59f2735
@michbeck100 michbeck100 mentioned this issue Mar 26, 2016
Closed
@michbeck100
Copy link
Owner Author

Comparing new value with current value to prevent infinite switching. Should be fixed now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.6.2
Development

No branches or pull requests
1 participant
@michbeck100