Skip to content

Commit

Permalink
[geo] turn off renderTrigger on viewport control (apache#4066)
Browse files Browse the repository at this point in the history
For context, the viewport gets updated dynamically from the user
actions on the map. This is done on a timer every second or so to keep
the form data updated with the viewport settings.

With renderTrigger=true on that control that generates re-renders which
introduces glitches while zooming/panning. So turning it off as we don't
really expect users to input viewport info directly in the control
anyways.
  • Loading branch information
mistercrunch authored and michellethomas committed May 23, 2018
1 parent 346aa18 commit 2137473
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion superset/assets/javascripts/explore/stores/controls.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -1446,7 +1446,7 @@ export const controls = {
viewport: {
type: 'ViewportControl',
label: t('Viewport'),
renderTrigger: true,
renderTrigger: false,
description: t('Parameters related to the view and perspective on the map'),
// default is whole world mostly centered
default: defaultViewport,
Expand Down

0 comments on commit 2137473

Please sign in to comment.