Skip to content

Commit

Permalink
Filter out unavailable databases (apache#3875)
Browse files Browse the repository at this point in the history
  • Loading branch information
dmigo authored and mistercrunch committed Nov 15, 2017
1 parent 2e25fc4 commit ae2205a
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions superset/views/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,14 @@ def apply(self, query, func): # noqa
return query.filter(self.model.perm.in_(perms))


class DatabaseFilter(SupersetFilter):
def apply(self, query, func):
if self.has_all_datasource_access():
return query
perms = self.get_view_menus('database_access')
return query.filter(self.model.perm.in_(perms))


class DashboardFilter(SupersetFilter):

"""List dashboards for which users have access to at least one slice"""
Expand Down Expand Up @@ -203,6 +211,7 @@ class DatabaseView(SupersetModelView, DeleteMixin): # noqa
]
add_template = 'superset/models/database/add.html'
edit_template = 'superset/models/database/edit.html'
base_filters = [['perm', DatabaseFilter, lambda:[]]]
base_order = ('changed_on', 'desc')
description_columns = {
'sqlalchemy_uri': utils.markdown(
Expand Down

0 comments on commit ae2205a

Please sign in to comment.