Avoid dividing by zero for sparkline in time table viz (apache#3679)

michellethomas · May 23, 2018 · aef77d1 · aef77d1
1 parent 59037fc
commit aef77d1
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/superset/assets/visualizations/time_table.jsx b/superset/assets/visualizations/time_table.jsx
@@ -72,7 +72,12 @@ function viz(slice, payload) {
           // Period ratio sparkline
           sparkData = [];
           for (let i = c.timeRatio; i < data.length; i++) {
-            sparkData.push(data[i][metric] / data[i - c.timeRatio][metric]);
+            const prevData = data[i - c.timeRatio][metric];
+            if (prevData && prevData !== 0) {
+              sparkData.push(data[i][metric] / prevData);
+            } else {
+              sparkData.push(null);
+            }
           }
         }
         const extent = d3.extent(sparkData);