Recommend using runtimeType in hash_and_equals

> Using `is` in `operator ==` is usually wrong as it makes the `==` operator asymmetric. dart-lang/sdk#36004 (comment)
micimize · Jan 8, 2020 · f8ccc3b · f8ccc3b
1 parent 015d9ea
commit f8ccc3b
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lib/src/rules/hash_and_equals.dart b/lib/src/rules/hash_and_equals.dart
@@ -39,7 +39,10 @@ class Better {
   Better(this.value);
 
   @override
-  bool operator ==(Object other) => other is Better && other.value == value;
+  bool operator ==(Object other) =>
+      other is Better &&
+      other.runtimeType == runtimeType &&
+      other.value == value;
 
   @override
   int get hashCode => value.hashCode;