Fix Union thread safety

Fixes `(*Set[V]).Union` to be thread safe properly. Signed-off-by: micnncim <micnncim@gmail.com>
micnncim · Sep 10, 2022 · 20bcf70 · 20bcf70
1 parent b2ef3ae
commit 20bcf70
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/set.go b/set.go
@@ -234,13 +234,13 @@ func (s *Set[V]) Values() []V {
 //	s.Union(t) = {a1, a2, a3, a4}
 //	t.Union(s) = {a1, a2, a3, a4}
 func (s *Set[V]) Union(t *Set[V]) *Set[V] {
-	u := s.Clone()
-
 	s.mux.RLock()
 	t.mux.RLock()
 	defer s.mux.RUnlock()
 	defer t.mux.RUnlock()
 
+	u := s.Clone()
+
 	for k := range t.m {
 		u.Insert(k)
 	}