Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with new databases #25

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Fix compatibility with new databases #25

merged 1 commit into from
Oct 29, 2023

Conversation

cdiener
Copy link
Contributor

@cdiener cdiener commented Oct 29, 2023

This fixes an issue with new model datbases that have rank prefixes in their taxonomy, for instance g__Prevotella. Those would fail to build since the table merger would always strip them.

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e5ca979) 91.53% compared to head (2309c3d) 91.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   91.53%   91.56%   +0.02%     
==========================================
  Files          11       11              
  Lines         319      320       +1     
  Branches       12       12              
==========================================
+ Hits          292      293       +1     
  Misses         26       26              
  Partials        1        1              
Files Coverage Δ
q2_micom/_build.py 94.28% <100.00%> (+0.16%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdiener cdiener merged commit 6c994b5 into main Oct 29, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant