Skip to content

Commit

Permalink
Put an argument list of 'void' where no arguments are expected. (ros2…
Browse files Browse the repository at this point in the history
…#899)

That's because in C, an empty argument list means "take any
arguments whatsoever".

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
  • Loading branch information
clalancette authored Mar 10, 2021
1 parent 9c150b0 commit 2be1219
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions rcl/include/rcl/logging.h
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ rcl_logging_configure_with_output_handler(
*/
RCL_PUBLIC
RCL_WARN_UNUSED
rcl_ret_t rcl_logging_fini();
rcl_ret_t rcl_logging_fini(void);

/// See if logging rosout is enabled.
/**
Expand All @@ -124,7 +124,7 @@ rcl_ret_t rcl_logging_fini();
*/
RCL_PUBLIC
RCL_WARN_UNUSED
bool rcl_logging_rosout_enabled();
bool rcl_logging_rosout_enabled(void);

/// Default output handler used by rcl.
/**
Expand Down
4 changes: 2 additions & 2 deletions rcl/src/rcl/logging.c
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ rcl_logging_configure(const rcl_arguments_t * global_args, const rcl_allocator_t
global_args, allocator, &rcl_logging_multiple_output_handler);
}

rcl_ret_t rcl_logging_fini()
rcl_ret_t rcl_logging_fini(void)
{
rcl_ret_t status = RCL_RET_OK;
rcutils_logging_set_output_handler(rcutils_logging_console_output_handler);
Expand All @@ -143,7 +143,7 @@ rcl_ret_t rcl_logging_fini()
return status;
}

bool rcl_logging_rosout_enabled()
bool rcl_logging_rosout_enabled(void)
{
return g_rcl_logging_rosout_enabled;
}
Expand Down

0 comments on commit 2be1219

Please sign in to comment.