Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add final attempt to reconnect in radio bridge #25

Merged
merged 9 commits into from
Aug 6, 2024
Merged

Conversation

microbit-grace
Copy link
Contributor

@microbit-grace microbit-grace requested review from a team and removed request for microbit-robert and a team August 5, 2024 10:01
@microbit-grace microbit-grace requested a review from a team August 5, 2024 15:24
Copy link
Contributor

@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and relicates the current behaviour in the ml prototype.

I've raised a few minor things, either for change or discussion, but would be happy to merge as is and come back to if necessary.

I don't know if it's possible or not, but it would be nice if, when we lost connection, we could probe the bridge device to see if it had been reset and then restart the communication between the micro:bits without having to wait for the connectTimeoutDuration which is currently 10 seconds. One to come back to.

@microbit-grace
Copy link
Contributor Author

I don't know if it's possible or not, but it would be nice if, when we lost connection, we could probe the bridge device to see if it had been reset and then restart the communication between the micro:bits without having to wait for the connectTimeoutDuration which is currently 10 seconds. One to come back to.

Interesting idea. That would be nice UX-wise, though yes, perhaps something to come back to.

Copy link
Contributor

@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@microbit-grace microbit-grace merged commit 09cbcad into main Aug 6, 2024
1 check passed
@microbit-grace microbit-grace deleted the radio-error branch August 6, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants