-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add final attempt to reconnect in radio bridge #25
Conversation
…ect so that software reset does not throw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and relicates the current behaviour in the ml prototype.
I've raised a few minor things, either for change or discussion, but would be happy to merge as is and come back to if necessary.
I don't know if it's possible or not, but it would be nice if, when we lost connection, we could probe the bridge device to see if it had been reset and then restart the communication between the micro:bits without having to wait for the connectTimeoutDuration
which is currently 10 seconds. One to come back to.
Interesting idea. That would be nice UX-wise, though yes, perhaps something to come back to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
In response to microbit-foundation/ml-trainer#281 (comment)