Fix bad firmware scenario #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-grace
commented
Dec 9, 2024
•
microbit-grace
commented
- Ensure that the bad firmware dialog is triggered in the bluetooth flow (not only in the radio flow). Previously, bad firmware would just prompt a manual flashing dialog for bluetooth flow.
- Remove "Skip and transfer manually" option in bad firmware dialog.
|
Preview build will be at |
microbit-grace
commented
Dec 9, 2024
There was a problem hiding this comment.
Found that bad firmware dialog was only popping up for radio flow and not for bluetooth flow. Changes in this file fixes the issue.
Additionally, removed a comment I added a while back in this file as the ConnectResult enum does make things more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.