Add missing Capability enum values #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ketNotifications.
|
@fritz-net @bytewizer @neildanson @mutiadavid @LuckyWraptor Tagging previous committers in this repository. Any chance I could get this and my other two PRs merged in? :-) |
This was referenced Sep 10, 2024
|
Thank you @logiclrd, this library only worked with your modifications regarding |
|
I agree. I couldn't wait indefinitely with my project and published a NuGet package with the changes merged. If they get accepted and published in the future, it should be easy enough to switch back to the main package. |
|
:-o :-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried to use this library today, I encountered errors trying to authenticate. After bashing my head against the wall trying to figure out what I was doing on for some time, I finally determined that the cause was actually nothing I was doing wrong. The JSON returned by Backblaze in response to successful authentication includes a list of Capability codes, and Backblaze have evidently added a couple of new ones, and the code blows up if it encounters Capability codes it doesn't recognize.
This PR adds new
Capabilityenum values for the new codes returned by Backblaze:ReadBucketNotificationsWriteBucketNotificationsI wonder also if there is some way to make the current structure of the code resilient to future changes of this type...