Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#175 introduced a potential dangerous change. If a user registers the regexp
.+
for scheme validation (as written in the comment) to allow all possible schemes, a link like<a href="javascript:...">
is valid too. The Go regexp module does not implement negative lookaheads, so you can't write "all but xyz" ((?!javascript|vbscript)
).This PR moves the regexp check a little bit down to be only executed if there was no other explicit scheme registration was found. So now
will allow every scheme but
javascript
.An alternative would be to drop
AllowURLSchemesMatching
again and add methodsDisallowURLSchemes
andDisallowURLSchemeWithCustomPolicy
.