Fix helm chart service port #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default chart configuration was broken due to a port mismatch between the default webhook port (443) and the chart's default service port (80). The result is the webhook always fails because kubernetes could not contact the webhook service on default port 443. Several fixes: - Use port 443 by default for the webhook service to match the k8s default - Specify the service port in the webhook configuration in case a non default port is specified in values
|
Thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default chart configuration was broken due to a port mismatch between the default webhook port (443) and the chart's default service port (80). The result is the webhook always fails because kubernetes could not contact the webhook service on default port 443.
Several fixes: