-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vcp: imply dates should also imply tz if needed #4
Comments
Use-case: https://indieweb.org/This_Week_in_Google where timezone is specified explicitly on the dt-start but not the dt-end. http://pin13.net/mf2/?url=https://indieweb.org/This_Week_in_Google provides (partial result) "start": [ Whereas it should say: "start": [ (note the "T" to " " change in separator for the dt-end property parsed result is already resolved by http://microformats.org/wiki/microformats2-parsing-issues#parsing_a_dt-_property ) |
microformats/php-mf2#131 adds this. |
I have missed this occasionally when editing events on the IndieWeb wiki. On the other hand, I also see the issue that it then becomes impossible to specify a time without TZ if any other property of the microfromat contains a time with TZ. This could cause problems e.g. on h-events which have dt-start/dt-end but also dt-published/dt-updated (the latter often being automatically generated). The parsing spec doesn't give use the ability to limit implied TZs to the same "category" of property, this would have to be a feature of the consuming applications and/or some kind of additional standardized processing algorithm. I'm unsure if this is an important scenario, but we'd break it with this change. |
This is implemented in php-mf2 since v0.4.0. I realize I did not first "broaden implementer consensus" per change control -- apologies for that. I think next steps before spec update are: broaden consensus, no objections, and explicit positive opinions by 2+ implementers. |
I am completely ambivalent about this. Can be added to mf2py if it makes into spec. |
I know I could only come up with a single objection to this, which I can’t track down right now, so I’ll put it in here for discussion. It also applies to the current implying of dates, but I didn’t see that as much of a problem as most things will likely include a date anyway. This change could hinder people using floating date-times on anything that gets published to an If I wanted to (re)post the HWC event to my blog, where a |
a proposal would be to implement this anyway, and note in the spec that this last comment's use case is a known flaw, but accept it anyway because it's outweighed by the benefit. (i don't actually care personally, just noting this proposal.) |
I think it was interesting that – without having read this issue – @snarfed raised this flaw at the Microformats parsing & vocabs, issues, proposals session at IndieWeb Summit 2018. Definitely makes me think there is something there, but it is hard to pin down. Probably because this flaw builds on very specific circumstances:
Is this a case where we should follow in the footsteps of implied properties and just make it a lot more specific to address a specific use-case?
It makes sense to me to have |
See my newer comment below |
Agree with @Zegnat. If someone wants to specify something that starts in one timezone and ends in another, it should be specified on each. |
I'm revisiting this after @tantek mentioned it in chat. At the end of https://microformats.org/wiki/value-class-pattern#microformats2_parsers_implied_date, it says
I initially +1 to @Zegnat's proposal because it seems to preserve publishers' intent and reduce unintended parsing side effects. Re-thinking it today, I realized it would move parsers "back" by requiring them to be aware of specific vocabularies and handle them in special ways. It does seem like something where the cases could grow over time if new dt-* properties are used. I'm leaning towards the initial proposal, perhaps with a caveat like #4 (comment). I don't love the unintended side effect, though I wonder how often that will happen in the wild. The main examples in our discussion were the former indieweb.org/events, but that's been superseded by events.indieweb.org which doesn't have the issue. |
In http://microformats.org/wiki/value-class-pattern#microformats2_parsers
Add:
The text was updated successfully, but these errors were encountered: